linux-kernel - Re: [PATCH 1/1] intel_ips: blacklist ASUSTek G60JX laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130814093836.57002b77@jbarnes-desktop>
Date:	Wed, 14 Aug 2013 09:38:36 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Joseph Salisbury <joseph.salisbury@...onical.com>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [PATCH 1/1] intel_ips: blacklist ASUSTek G60JX laptops

On Wed, 14 Aug 2013 12:22:49 -0400
Joseph Salisbury <joseph.salisbury@...onical.com> wrote:

> BugLink: http://bugs.launchpad.net/bugs/1210848
> 
> On an ASUSTek G60JX laptop, the intel_ips driver spams the log with a warning message: "ME failed to update for more than 1s, likely hung".  This ME doesn't support the feature, so requesting it be blacklisted for now.   
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@...onical.com>
> Tested-by: Nick Jenkins <tech.crew.jenkins@...il.com> 
> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> Cc: platform-driver-x86@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> ---
>  drivers/platform/x86/intel_ips.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 18dcb58..6d8c5e0 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1501,6 +1501,14 @@ static const struct dmi_system_id ips_blacklist[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),
>  		},
>  	},
> +	{
> +		.callback = ips_blacklist_callback,
> +		.ident = "G60JX",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "G60JX"),
> +		},
> +	},
>  	{ }	/* terminating entry */
>  };
>  

Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Linus, you may want to pick this up directly, as I'm not sure if
Matthew is still looking after the x86 drivers these days.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/