linux-kernel - Re: [PATCH] usb: misc: usb3503: Force late initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130814182239.GC23847@kroah.com>
Date:	Wed, 14 Aug 2013 11:22:39 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	tobetter@...il.com, broonie@...aro.org, patches@...aro.org
Subject: Re: [PATCH] usb: misc: usb3503: Force late initialization

On Wed, Aug 14, 2013 at 03:59:31PM +0530, Tushar Behera wrote:
> USB3503 chip needs to be reset after the USB PHY controller has been
> intiliazed, otherwise it is not detected as plugged in.

Why not?

> Currently there is no other way to ensure that USB3503 chip is probed
> after the USB PHY has been initialized, hence the last resort.

Are you sure that deferred probing doesn't solve this issue?

> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> ---
>  drivers/usb/misc/usb3503.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index a31641e..ad8368d 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -339,7 +339,7 @@ static int __init usb3503_init(void)
>  
>  	return 0;
>  }
> -module_init(usb3503_init);
> +late_initcall(usb3503_init);

I really hate stuff like this, that is what the change to the driver
core for the deferred probe work was for, could you please look into
that instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/