[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <520BD275.5060004@cogentembedded.com>
Date: Wed, 14 Aug 2013 22:54:45 +0400
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Libo Chen <clbchenlibo.chen@...wei.com>
CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
Hello.
On 08/14/2013 07:39 AM, Libo Chen wrote:
> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
You misunderstood. That's a material for 2 separate patch sets (or maybe
single patches, since multiple files can be collapsed in a single patch).
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists