linux-kernel - Re: [PATCH v2] staging: gdm7240: a TTY rewrite according to the latest TTY APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Aug 2013 14:12:00 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Won Kang <wkang77@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	sachin.kamat@...aro.org, yongjun_wei@...ndmicro.com.cn,
	wonkang@...semi.com, joe@...ches.com, dan.carpenter@...cle.com
Subject: Re: [PATCH v2] staging: gdm7240: a TTY rewrite according to the
 latest TTY APIs

On Tue, Aug 13, 2013 at 07:46:01PM +0900, Won Kang wrote:
> Removed the old style reference countings and termios.
> Renamed variables to meaninful ones.
> 
> Fixed mis-use of mutex for gdm_table. gdm_table is refered to only
> inside tty_install and port destrcut, and usb callbacks use internal
> reference which was saved during urb submission
> 
> Signed-off-by: Won Kang <wonkang@...semi.com>
> ---
> v2: fixed mutex bug, added ChangeLog, added missing kfree
>  drivers/staging/gdm724x/ChangeLog |   62 ++++++++

Why a changelog?  The kernel has a changelog, in the git commit log, if
every individual driver had a separate changelog, the tree would be a
mess, right?  It also looks like you included things that are already in
the kernel changelog (patches from me and others), so this is duplicated
effort.

>  drivers/staging/gdm724x/gdm_mux.c |    9 +-
>  drivers/staging/gdm724x/gdm_mux.h |   14 +-
>  drivers/staging/gdm724x/gdm_tty.c |  295 +++++++++++++++++--------------------
>  drivers/staging/gdm724x/gdm_tty.h |   36 +++--
>  5 files changed, 237 insertions(+), 179 deletions(-)
>  create mode 100644 drivers/staging/gdm724x/ChangeLog
> 
> diff --git a/drivers/staging/gdm724x/ChangeLog b/drivers/staging/gdm724x/ChangeLog
> new file mode 100644
> index 0000000..506e60e
> --- /dev/null
> +++ b/drivers/staging/gdm724x/ChangeLog
> @@ -0,0 +1,62 @@
> +2013-08-13  Won Kang <wonkang@...semi.com>
> +	* Fixed mis-use of mutex for gdm_table. gdm_table is refered to only
> +	* inside tty_install and port destrcut, and usb callbacks use internal
> +	* reference which was saved during urb submission
> +
> +2013-08-09  Won Kang <wonkang@...semi.com>
> +	* A rewrite was needed to properly use latest TTY AAPI
> +	*
> +	* Original TTY codes were written from kernel 2.6.x, doing tty reference
> +	* counting within the this driver. This is fixed to use tty core APIs.
> +	*
> +	* The usage count of tty port is no longer handled by the driver.
> +	*
> +	* termios members of tty_operations as the ports are virtual and
> +	* have no real effect.
> +	*
> +	* Renamed variables to be more clear as they were confusing due to the
> +	* similarities with the tty core structures.

Please send these two patches, not mushed together as one, so I can
apply them that way.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/