linux-kernel - Re: [PATCH] userns: initialize the depth of user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520B2768.1090001@huawei.com>
Date:	Wed, 14 Aug 2013 14:44:56 +0800
From:	Rui Xiang <rui.xiang@...wei.com>
To:	Andy Lutomirski <luto@...capital.net>
CC:	<linux-kernel@...r.kernel.org>, <oleg@...hat.com>
Subject: Re: [PATCH] userns: initialize the depth of user_namespace chain

On 2013/8/14 13:06, Andy Lutomirski wrote:
> On Tue, Aug 13, 2013 at 10:04 PM, Rui Xiang <rui.xiang@...wei.com> wrote:
>> The level of init_user_ns shoule be 1.
> 
> What's wrong with zero?
> 

No problem. It is just consistent with commit 8742f229b63, IMHO.
but the initialization of level should be necessary.


Thanks.

> --Andy
> 
>>
>> Signed-off-by: Rui Xiang <rui.xiang@...wei.com>
>> ---
>>  kernel/user.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/user.c b/kernel/user.c
>> index 69b4c3d..32da187 100644
>> --- a/kernel/user.c
>> +++ b/kernel/user.c
>> @@ -48,6 +48,7 @@ struct user_namespace init_user_ns = {
>>                 },
>>         },
>>         .count = ATOMIC_INIT(3),
>> +       .level = 1,
>>         .owner = GLOBAL_ROOT_UID,
>>         .group = GLOBAL_ROOT_GID,
>>         .proc_inum = PROC_USER_INIT_INO,
>> --
>> 1.8.2.2
>>
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/