linux-kernel - Re: [PATCH 28/29] drivers/input/{keyboard,serio}: simplify use of devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130815070936.GB15691@core.coreip.homeip.net>
Date:	Thu, 15 Aug 2013 00:09:36 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	kernel-janitors@...r.kernel.org, linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH 28/29] drivers/input/{keyboard,serio}: simplify use of
 devm_ioremap_resource

On Wed, Aug 14, 2013 at 04:51:02PM +0530, Viresh Kumar wrote:
> On Wed, Aug 14, 2013 at 4:33 PM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> > From: Julia Lawall <Julia.Lawall@...6.fr>
> >
> > Remove unneeded error handling on the result of a call to
> > platform_get_resource when the value is passed to devm_ioremap_resource.
> >
> > Move the call to platform_get_resource adjacent to the call to
> > devm_ioremap_resource to make the connection between them more clear.
> >
> > A simplified version of the semantic patch that makes this change is as
> > follows: (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression pdev,res,n,e,e1;
> > expression ret != 0;
> > identifier l;
> > @@
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, n);
> >   ... when != res
> > - if (res == NULL) { ... \(goto l;\|return ret;\) }
> >   ... when != res
> > + res = platform_get_resource(pdev, IORESOURCE_MEM, n);
> >   e = devm_ioremap_resource(e1, res);
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> >
> > ---
> 
> >  drivers/input/keyboard/spear-keyboard.c |    7 +------
> 
> For SPEAr:
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Thanks, applied.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/