linux-kernel - Re: [PATCH 03/10] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <162759CE-0031-4571-A4A3-3BFE16445066@suse.de>
Date:	Thu, 15 Aug 2013 09:43:34 +0200
From:	Alexander Graf <agraf@...e.de>
To:	Alexey Kardashevskiy <aik@...abs.ru>
Cc:	linuxppc-dev@...ts.ozlabs.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>, kvm@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kvm-ppc@...r.kernel.org
Subject: Re: [PATCH 03/10] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO


On 15.08.2013, at 09:42, Alexey Kardashevskiy wrote:

> On 08/15/2013 05:25 PM, Alexander Graf wrote:
>> 
>> On 15.08.2013, at 09:24, Alexander Graf wrote:
>> 
>>> 
>>> On 15.08.2013, at 09:22, Alexey Kardashevskiy wrote:
>>> 
>>>> On 08/15/2013 05:16 PM, Alexander Graf wrote:
>>>>> 
>>>>> On 01.08.2013, at 06:44, Alexey Kardashevskiy wrote:
>>>>> 
>>>>>> This is to reserve a capablity number for upcoming support
>>>>>> of VFIO-IOMMU DMA operations in real mode.
>>>>>> 
>>>>>> Signed-off-by: Alexey Kardashevskiy <aik@...abs.ru>
>>>>>> 
>>>>>> ---
>>>>>> Changes:
>>>>>> 2013/07/16:
>>>>>> * changed the number
>>>>>> 
>>>>>> 2013/07/11:
>>>>>> * changed order in a file, added comment about a gap in ioctl number
>>>>>> 
>>>>>> Signed-off-by: Alexey Kardashevskiy <aik@...abs.ru>
>>>>>> ---
>>>>>> include/uapi/linux/kvm.h | 4 ++++
>>>>>> 1 file changed, 4 insertions(+)
>>>>>> 
>>>>>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>>>>>> index 99c2533..53c3f1f 100644
>>>>>> --- a/include/uapi/linux/kvm.h
>>>>>> +++ b/include/uapi/linux/kvm.h
>>>>>> @@ -668,6 +668,7 @@ struct kvm_ppc_smmu_info {
>>>>>> #define KVM_CAP_IRQ_XICS 92
>>>>>> #define KVM_CAP_ARM_EL1_32BIT 93
>>>>>> #define KVM_CAP_SPAPR_MULTITCE 94
>>>>>> +#define KVM_CAP_SPAPR_TCE_IOMMU 95
>>>>>> 
>>>>>> #ifdef KVM_CAP_IRQ_ROUTING
>>>>>> 
>>>>>> @@ -933,6 +934,9 @@ struct kvm_s390_ucas_mapping {
>>>>>> #define KVM_ARM_SET_DEVICE_ADDR	  _IOW(KVMIO,  0xab, struct kvm_arm_device_addr)
>>>>>> /* Available with KVM_CAP_PPC_RTAS */
>>>>>> #define KVM_PPC_RTAS_DEFINE_TOKEN _IOW(KVMIO,  0xac, struct kvm_rtas_token_args)
>>>>>> +/* 0xad and 0xaf are already taken */
>>>>> 
>>>>> so 0xad and 0xaf are already taken? where?
>>>> 
>>>> Mistype :( s/af/ae/
>>>> 
>>>> They are taken in this file:
>>>> 
>>>> 1016 /* VM is being stopped by host */
>>>> 1017 #define KVM_KVMCLOCK_CTRL         _IO(KVMIO,   0xad)
>>>> 1018 #define KVM_ARM_VCPU_INIT         _IOW(KVMIO,  0xae, struct kvm_vcpu_init)
>>> 
>>> Could you please make sure that whoever reads the comment in a year still knows where to look? :)
>> 
>> Something like
>> 
>>  /* 0xad is taken by KVM_KVMCLOCK_CTRL */
>>  /* 0xaf is taken by KVM_ARM_VCPU_INIT */
> 
> 
> Missed this mail and reposted without this comment but updated commit
> message saying where they are used. Repost again?

The commit message doesn't really help, since you don't see that one when you read the header file later. So yes, please.


Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/