linux-kernel - Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Aug 2013 14:37:00 +0530
From:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>
To:	Zhang Rui <rui.zhang@...el.com>
Cc:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-pm@...r.kernel.org, eduardo.valentin@...com,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org,
	amit.daniel@...sung.com, Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

On 15 August 2013 12:32, Zhang Rui <rui.zhang@...el.com> wrote:
>
> On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote:
> > The error check is checking for a "base" mapped memory base
> > instead of "base_common". Fixing the same.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
>
> applied. Thanks!
> BTW, can you rebase the other three exynos patches you submitted?
I mistakenly rebased on the master branch.
Later found the code base is a lot different in the for-next branch.
I've it in my pipe line, Will submit at the soon.

Thanks Rui,

>
> thanks,
> rui
> > ---
> >  drivers/thermal/samsung/exynos_tmu.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> > index ec01dfe..a033dbb 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
> >
> >       data->base_common = devm_ioremap(&pdev->dev, res.start,
> >                                       resource_size(&res));
> > -     if (!data->base) {
> > +     if (!data->base_common) {
> >               dev_err(&pdev->dev, "Failed to ioremap memory\n");
> >               return -ENOMEM;
> >       }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/




-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/