linux-kernel - Re: [PATCH] i2c: mxs: Better error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130815100331.GD2987@katana>
Date:	Thu, 15 Aug 2013 12:03:31 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	marex@...x.de
Subject: Re: [PATCH] i2c: mxs: Better error handling

On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote:
> This patch fixes two error handling cases in mxs_i2c_xfer_msg():
> 
>  - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c->cmd_err
>  will not be set so mxs_i2c_xfer_msg() fails silently.
> 
>  - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have
>  i2c->cmd_err set to -ENXIO. In that case, we want to go through the
>  MXS_I2C_CTRL1_CLR_GOT_A_NAK before returning.

A short explanation why we want that would be perfect.

> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

I'd like to postpone this until I applied Marek's PIO rework. Could you
respin after that?


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)