[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130815164024.GB15688@kroah.com>
Date: Thu, 15 Aug 2013 09:40:24 -0700
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc: Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs
in groups
On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote:
> Hello Greg,
> looking through the patch I found the following:
>
>
>
> In hid-roccat-kone.c, PROFILE_ATTR macro:
> The line
> .private = &profile_numbers[number],
> should read
> .private = &profile_numbers[number-1],
Ah, ok, thanks, will fix up.
> Regarding the compiler warning about unused pyra_sysfs_write_settings:
> The attribute is indeed readwrite, but the code to write is not standard
> code. The read function was created with the PYRA_SYSFS_R macro and the
> write function was written manually. Used were both by
> PYRA_BIN_ATTRIBUTE_RW.
> In this case I would keep the PYRA_SYSFS_* macros standalone so that the
> calling code looks like this:
>
> PYRA_SYSFS_W(control, CONTROL);
> PYRA_SYSFS_RW(info, INFO);
> PYRA_SYSFS_RW(profile_settings, PROFILE_SETTINGS);
> PYRA_SYSFS_RW(profile_buttons, PROFILE_BUTTONS);
> PYRA_SYSFS_R(settings, SETTINGS);
>
> PYRA_BIN_ATTRIBUTE_W(control, CONTROL);
> PYRA_BIN_ATTRIBUTE_RW(info, INFO);
> PYRA_BIN_ATTRIBUTE_RW(profile_settings, PROFILE_SETTINGS);
> PYRA_BIN_ATTRIBUTE_RW(profile_buttons, PROFILE_BUTTONS);
> PYRA_BIN_ATTRIBUTE_RW(settings, SETTINGS);
Hm, I'll look this over again and see if I can make it better.
But why are you using a "non standard" write function? What is special
here about this?
> Another thing: Why does nobody (besides me) use the get_maintainer.pl
> script, so I have to search manually for patches regarding my code?
I did use it:
$ ./scripts/get_maintainer.pl --file drivers/hid/hid-roccat-kone.c
Jiri Kosina <jkosina@...e.cz> (maintainer:HID CORE LAYER)
linux-input@...r.kernel.org (open list:HID CORE LAYER)
linux-kernel@...r.kernel.org (open list)
You aren't listed there, perhaps a MAINTAINERS entry needs to be added?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists