linux-kernel - Re: [PATCH 2/2] ipc/mq: Removed unused def_attr local variable and its initialization in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <520D34D7.9080208@redhat.com>
Date:	Thu, 15 Aug 2013 16:06:47 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Sasikantha Babu <sasikanth.v19@...il.com>
CC:	Al Viro <viro@...iv.linux.org.uk>,
	Jeff Layton <jlayton@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Vladimir Davydov <vdavydov@...allels.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ipc/mq: Removed unused def_attr local variable and
 its initialization in do_create

On 08/12/2013 11:09 AM, Sasikantha Babu wrote:
> In the first patch since we removed calling mq_attr_ok to validate
> mqueue attributes default/ceil values, So removing the unused def_attr
> 
> Signed-off-by: Sasikantha Babu <sasikanth.v19@...il.com>
> ---
>  ipc/mqueue.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 04ece80..0bcf69c 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -741,13 +741,6 @@ static struct file *do_create(struct ipc_namespace *ipc_ns, struct inode *dir,
>  			return ERR_PTR(ret);
>  		/* store for use during create */
>  		path->dentry->d_fsdata = attr;
> -	} else {
> -		struct mq_attr def_attr;
> -
> -		def_attr.mq_maxmsg = min(ipc_ns->mq_msg_max,
> -					 ipc_ns->mq_msg_default);
> -		def_attr.mq_msgsize = min(ipc_ns->mq_msgsize_max,
> -					  ipc_ns->mq_msgsize_default);
>  	}
>  
>  	mode &= ~current_umask();
> 

Nak to this patch as well since it depends on the previous patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/