linux-kernel - Re: [PATCH v2] Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130815141848.0af8cc27fa852905a35b02f8@linux-foundation.org>
Date:	Thu, 15 Aug 2013 14:18:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Sergei Trofimovich <slyfox@...too.org>
Cc:	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v2] Makefile: enable -Werror=implicit-int and
 -Werror=strict-prototypes by default

On Thu, 15 Aug 2013 21:37:31 +0300 Sergei Trofimovich <slyfox@...too.org> wrote:

> The common error type found in forward-ported/backported patches is missing headers.
> One recent example (files and function names are mangled):
> 
>     void foo(){}
>     EXPORT_SYMBOL(foo);
> 
> gave only warning
> 
>     foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes]
>     void foo(){}
>          ^
> 
>     foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default]
>     EXPORT_SYMBOL(foo);
>     foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int]
> 
> Now it's a fata error. Tested on x86_64 allyesconfig.

Yes, let's try that.

Partly because the build still generates far too many warnings..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/