linux-kernel - Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130816001716.GA7367@kroah.com>
Date:	Thu, 15 Aug 2013 17:17:16 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dmitry Kasatkin <d.kasatkin@...sung.com>,
	sarah.a.sharp@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org, sarah.a.sharp@...ux.intel.com,
	dmitry.kasatkin@...il.com
Subject: Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is
 not enabled

On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote:
> When debug is not enabled and dev_dbg() will expand to nothing,
> log might be flooded with "callbacks suppressed". If it was not
> done on purpose, better to use dev_dbg_ratelimited() instead.
> 
> Signed-off-by: Dmitry Kasatkin <d.kasatkin@...sung.com>
> ---
>  drivers/usb/host/xhci-ring.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)


Sarah, does this patch conflict with the trace debug patches being
worked on?  I'll hold off on applying it for now, let me know if it's ok
or not.

thanks,

greg k-h
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 5b08cd8..5298232 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -3060,8 +3060,7 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
>  	 * to set the polling interval (once the API is added).
>  	 */
>  	if (xhci_interval != ep_interval) {
> -		if (printk_ratelimit())
> -			dev_dbg(&urb->dev->dev, "Driver uses different interval"
> +		dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval"
>  					" (%d microframe%s) than xHCI "
>  					"(%d microframe%s)\n",
>  					ep_interval,
> @@ -3849,8 +3848,7 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd *xhci, gfp_t mem_flags,
>  	 * to set the polling interval (once the API is added).
>  	 */
>  	if (xhci_interval != ep_interval) {
> -		if (printk_ratelimit())
> -			dev_dbg(&urb->dev->dev, "Driver uses different interval"
> +		dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval"
>  					" (%d microframe%s) than xHCI "
>  					"(%d microframe%s)\n",
>  					ep_interval,
> -- 
> 1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/