linux-kernel - Re: [PATCH v3 0/2] rtc: omap: update AM335x rtc ip revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520E17BE.2050008@ti.com>
Date:	Fri, 16 Aug 2013 17:44:54 +0530
From:	Gururaja Hebbar <gururaja.hebbar@...com>
To:	unlisted-recipients:; (no To-header on input)
CC:	<akpm@...ux-foundation.org>, <khilman@...aro.org>,
	<tony@...mide.com>, <bcousson@...libre.com>,
	<rob.herring@...xeda.com>, <mark.rutland@....com>,
	<a.zummo@...ertech.it>, <rob@...dley.net>,
	<grant.likely@...aro.org>, <rtc-linux@...glegroups.com>,
	<linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	<sudhakar.raj@...com>
Subject: Re: [PATCH v3 0/2] rtc: omap: update AM335x rtc ip revision

Hi All,

Kindly ignore this series. there is mistake/typo because of which it
will not directly apply. I will resend the patch-set.

sorry for the trouble.

regards
Gururaja

On 8/16/2013 5:06 PM, Hebbar, Gururaja wrote:
> The syntax of compatible property in DT is to mention the Most specific
> match to most generic match.
> 
> Since AM335x is the platform with latest IP revision, add it 1st in
> the device id table.
> 
> This way, we can add new matching compatible as 1st and maintain old
> compatible string for backwards compatibility.
> 
> ex:
> 	compatible = "ti,am3352-rtc", "ti,da830-rtc";
> 
> Also, update am335x .dtsi file (am33xx.dtsi) as above.
> 
> Note:
> This is a part of previously submitted patch-set [1]. Out of 4 patches,
> 3 was accepted and 1 got an acceptable NAK. Hence resubmitting only the
> rejected + updated changes.
> 
> Changes in V3:
> 	- As per Mark Rutland's suggestion [2], maintain old compatible
> 	  string and add the new matching string as the 1st compatible.
> 
> Changes in V2:
> 	- Coding style corrections (remove extra space, use lower case
> 	  for hex numbers
> 	- use prefix ARM: for commit subject keeping with arch/arm
> 	  convention)
> 	- use "[AM/am]3352" instead of "[AM/am]335x" to keep the all
> 	  usages in sync.
> 	- Use index defined for struct members so they remain in sync
> 	- Add new compatible to existing one so that when driver
> 	  supports enhanced features of hardware, they are available
> 	  to the user else the basic functionality still works
> 
> [2]
> https://lkml.org/lkml/2013/7/3/74
> [1]
> https://lkml.org/lkml/2013/8/1/442
> 
> Hebbar Gururaja (1):
>   ARM: dts: AM33XX: update rtc node compatibility
> 
> Hebbar, Gururaja (1):
>   rtc: omap: update of_device_id to reflect latest ip revisions
> 
>  arch/arm/boot/dts/am33xx.dtsi |    2 +-
>  drivers/rtc/rtc-omap.c        |    6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/