linux-kernel - Re: [RFC PATCH] Fix aio performance regression for database caused by THP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <520E33D1.4040005@oracle.com>
Date:	Fri, 16 Aug 2013 08:14:41 -0600
From:	Khalid Aziz <khalid.aziz@...cle.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>,
	akpm@...ux-foundation.org
CC:	aarcange@...hat.com, hannes@...xchg.org, mgorman@...e.de,
	riel@...hat.com, minchan@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] Fix aio performance regression for database caused
 by THP

On 08/16/2013 03:04 AM, Kirill A. Shutemov wrote:
> On Thu, Aug 15, 2013 at 12:13:09PM -0600, Khalid Aziz wrote:
>>
>> -	if (likely(page != page_head && get_page_unless_zero(page_head))) {
>> +	/*
>> +	 * If this is a hugetlbfs page, it can not be split under
>> +	 * us. Simply increment refcount for head page
>> +	 */
>> +	if (PageHuge(page)) {
>> +		page_head = compound_head(page);
>> +		atomic_inc(&page_head->_count);
>> +		got = true;
>
> Why not just return here and don't increase indentantion level for rest of
> the function?
>

Good point.

Andrew, I can rework the patch if you would like.

Thanks,
Khalid
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/