lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Aug 2013 01:57:20 +0900 From: JoonSoo Kim <js1304@...il.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>, Ingo Molnar <mingo@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Mike Galbraith <efault@....de>, Paul Turner <pjt@...gle.com>, Alex Shi <alex.shi@...el.com>, Preeti U Murthy <preeti@...ux.vnet.ibm.com>, Vincent Guittot <vincent.guittot@...aro.org>, Morten Rasmussen <morten.rasmussen@....com>, Namhyung Kim <namhyung@...nel.org> Subject: Re: [PATCH v3 2/3] sched: factor out code to should_we_balance() >> +static int should_we_balance(struct lb_env *env) >> +{ >> + struct sched_group *sg = env->sd->groups; >> + struct cpumask *sg_cpus, *sg_mask; >> + int cpu, balance_cpu = -1; >> + >> + /* >> + * In the newly idle case, we will allow all the cpu's >> + * to do the newly idle load balance. >> + */ >> + if (env->idle == CPU_NEWLY_IDLE) >> + return 1; >> + >> + sg_cpus = sched_group_cpus(sg); >> + sg_mask = sched_group_mask(sg); >> + /* Try to find first idle cpu */ >> + for_each_cpu_and(cpu, sg_cpus, env->cpus) { >> + if (!cpumask_test_cpu(cpu, sg_mask) || idle_cpu(cpu)) > > Did you want to write !idle_cpu() ? > You are right. I made a mistake when I wrote v2 for style change. Thanks for spotting this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists