linux-kernel - Re: [PATCH] usb: phy: am335x-control: make it compile with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520E68A9.1020406@infradead.org>
Date:	Fri, 16 Aug 2013 11:00:09 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
CC:	Felipe Balbi <balbi@...com>, Roger Quadros <rogerq@...com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	USB list <linux-usb@...r.kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] usb: phy: am335x-control: make it compile with

On 08/16/13 08:32, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> Randy reported this
> |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration
> |of function '__WARN' [-Werror=implicit-function-declaration]
> 
> and left it as an excercice to figure out that this happens only with
> CONFIG_BUG=n. As a fix I replace it with WARN_ON(). And there is a space
> before return so fix this, too.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/usb/phy/phy-am335x-control.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c
> index 7597545..22cf07d 100644
> --- a/drivers/usb/phy/phy-am335x-control.c
> +++ b/drivers/usb/phy/phy-am335x-control.c
> @@ -42,8 +42,8 @@ static void am335x_phy_power(struct phy_control *phy_ctrl, u32 id, bool on)
>  		reg = AM335X_USB1_CTRL;
>  		break;
>  	default:
> -		__WARN();
> -		 return;
> +		WARN_ON(1);
> +		return;
>  	}
>  
>  	val = readl(usb_ctrl->phy_reg + reg);
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/