linux-kernel - Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHfPSqBnj2OTHdbnW3SCRf7SL1maMsWau1+9DWFLYRBM+1HOJQ@mail.gmail.com>
Date:	Fri, 16 Aug 2013 10:28:23 +0530
From:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Tomasz Figa <t.figa@...sung.com>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	devicetree-discuss@...ts.ozlabs.org,
	Kukjin Kim <kgene.kim@...sung.com>, grant.likely@...retlab.ca,
	linux-kernel@...r.kernel.org, taeggyun.ko@...sung.com,
	balbi@...com, thomas.abraham@...aro.org
Subject: Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

On 15 August 2013 18:42, Wolfram Sang <wsa@...-dreams.de> wrote:
> On Mon, Jul 01, 2013 at 12:25:19PM +0200, Tomasz Figa wrote:
>> Hi Naveen,
>>
>> Looks mostly good, but see some comments inline.
>
> Ping?
Hello Wolfram,

I made a patch fixing your comments and from Thomas Figa as well.

Meanwhile, we hit a random crash in exynos5_i2c_irq function.
The "len" variable being is still being near the FIFO_MAX after this condition
 len = HSI2C_FIFO_MAX - fifo_level;
 +             if (len > i2c->msg->len)
 +                     len = i2c->msg->len;

Once, we fix this problem. i planned to rebase and submit.

Is it okey with you?

Thanks,
Naveen
>



-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/