linux-kernel - Re: [PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 17 Aug 2013 19:46:30 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, dhowells@...hat.com,
	edumazet@...gle.com, darren@...art.com, fweisbec@...il.com,
	sbw@....edu
Subject: Re: [PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

On Sat, Aug 17, 2013 at 06:25:52PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>

Could you mention the BibTeX formatting changes (and the rationale for
them) in the commit message, please?

> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

A couple of comments below (and above); with those fixed,
Reviewed-by: Josh Triplett <josh@...htriplett.org>

> ---
>  Documentation/RCU/RTFP.txt | 855 +++++++++++++++++++++++++++++----------------
>  1 file changed, 550 insertions(+), 305 deletions(-)
> 
> diff --git a/Documentation/RCU/RTFP.txt b/Documentation/RCU/RTFP.txt
> index 7f40c72..350be9a 100644
> --- a/Documentation/RCU/RTFP.txt
> +++ b/Documentation/RCU/RTFP.txt
> @@ -39,7 +39,7 @@ in read-mostly situations.  This algorithm does take pains to avoid
>  write-side contention and parallelize the other write-side overheads by
>  providing a fine-grained locking design, however, it would be interesting
>  to see how much of the performance advantage reported in 1990 remains
> -in 2004.
> +in 2004 (to say nothing of 2013).

In lieu of updating this again in 9 years, s/2004.*/today./ please?

> +In 2012, Josh Triplett received his Ph.D. with his dissertation
> +covering RCU-protected resizable hash tables and the relationship
> +between memory barriers and read-side traversal order:  If the updater
> +is making changes in the opposite direction from the read-side traveral
> +order, the updater need only execute a memory-barrier instruction,
> +but if in the same direction, the updater needs to wait for a grace
> +period between the individual updates [JoshTriplettPhD].  Also in 2012,

:)

> +after seventeen years of attempts, an RCU paper made it into a top-flight
> +academic journal, IEEE Transactions on Parallel and Distributed Systems
> +[MathieuDesnoyers2012URCU].  A group of researchers in Spain applied

What about the 2010 paper in Operating Systems Review?

> +user-level RCU to crowd simulation [GuillermoVigueras2012RCUCrowd], and
> +another group of researchers in Europe produced a formal description of
> +RCU based on separation logic [AlexeyGotsman2012VerifyGraceExtended],

Oh, interesting, I hadn't seen that one yet.

> +@...thesis{JoshTriplettPhD
> +,author="Josh Triplett"
> +,title="Relativistic Causal Ordering A Memory Model for Scalable Concurrent Data Structures"

"A Memory Model ..." is a subtitle, so there should be either a : or a
--- after "Ordering".

> +,school="Portland State University"
> +,year="2012"
> +,annotation={
> +	RCU-protected hash tables, barriers vs. read-side traversal order.
> +}

Consider duplicating the summary above about traversal order versus
update order, and memory barriers versus grace periods, into the
annotation.

> +@...icle{GuillermoVigueras2012RCUCrowd
> +,author = {Vigueras, Guillermo and Ordu\~{n}a, Juan M. and Lozano, Miguel}
> +,citeulike-article-id = {10632151}
> +,citeulike-linkout-0 = {http://dx.doi.org/10.1007/s11227-012-0766-x}
> +,citeulike-linkout-1 = {http://www.springerlink.com/content/25762r0874163570}

Consider dropping these non-standard BibTeX tags; nothing will ever
format them, and you already have the doi below.

> +,day = {25}
> +,doi = {10.1007/s11227-012-0766-x}
> +,issn = {0920-8542}
> +,journal = {The Journal of Supercomputing}
> +,keywords = {linux, simulation}
> +,month = apr
> +,posted-at = {2012-05-03 09:12:04}
> +,priority = {2}
> +,title = {{A Read-Copy Update based parallel server for distributed crowd simulations}}
> +,url = {http://dx.doi.org/10.1007/s11227-012-0766-x}
> +,year = {2012}
> +}
> +
> +
> +@...ublished{JonCorbet2012ACCESS:ONCE

LWN is not "unpublished"; it's at least "misc", and I'd suggest
"article".  Ditto for every other LWN cite in this bibliography.

> +,Author="Jon Corbet"
> +,Title="{ACCESS\_ONCE()}"
> +,month="August"
> +,day="1"
> +,year="2012"
> +,note="\url{http://lwn.net/Articles/508991/}"
> +,annotation={
> +	A couple of simple specific compiler optimizations that motivate
> +	ACCESS_ONCE().
> +}
> +}

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/