linux-kernel - Re: [PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle arguments to API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130818031120.GJ28923@leaf>
Date:	Sat, 17 Aug 2013 20:11:20 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, dhowells@...hat.com,
	edumazet@...gle.com, darren@...art.com, fweisbec@...il.com,
	sbw@....edu
Subject: Re: [PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle
 arguments to API

On Sat, Aug 17, 2013 at 06:49:42PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> 
> This commit adds an isidle and jiffies argument to force_qs_rnp(),
> dyntick_save_progress_counter(), and rcu_implicit_dynticks_qs() to enable
> RCU's force-quiescent-state process to check for full-system idle.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Lai Jiangshan <laijs@...fujitsu.com>
> [ paulmck: Use true and false for boolean constants per Lai Jiangshan. ]

One optional comment below; with or without that,
Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  kernel/rcutree.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index b0d2cc3..f1a0b05 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -246,7 +246,9 @@ module_param(jiffies_till_next_fqs, ulong, 0644);
>  
>  static void rcu_start_gp_advanced(struct rcu_state *rsp, struct rcu_node *rnp,
>  				  struct rcu_data *rdp);
> -static void force_qs_rnp(struct rcu_state *rsp, int (*f)(struct rcu_data *));
> +static void force_qs_rnp(struct rcu_state *rsp,
> +			 int (*f)(struct rcu_data *, bool *, unsigned long *),
> +			 bool *isidle, unsigned long *maxj);

You might consider giving the parameters of the function pointer names
(both here and in the definition), to make it more self-documenting.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/