linux-kernel - Re: [PATCH 05/35] i2c: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <015c01ce9c7b$8da0f710$a8e2e530$@samsung.com>
Date:	Mon, 19 Aug 2013 10:29:31 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Wolfram Sang' <wsa@...-dreams.de>
Cc:	'Wolfram Sang' <wolfram@...-dreams.de>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH 05/35] i2c: use dev_get_platdata()

On Friday, August 16, 2013 3:03 AM, Wolfram Sang wrote:
> On Tue, Jul 30, 2013 at 04:59:33PM +0900, Jingoo Han wrote:
> > Use the wrapper function for retrieving the platform data instead of
> > accessing dev->platform_data directly.
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> 
> Not convincing. I couldn't find a cover letter explaining the motivation
> and if this should go via the seperate trees or via one cleanup pull
> request. (and if there is one, the i2c list should be on cc) Also, all

CC'ed Mark Brown (author of dev_get_platdata function)

1. Motivation
This is a cosmetic change by in order to enhance readability and make
the code simpler.

If you want, I will modify the commit message as below:
"Use the wrapper function for retrieving the platform data instead of
 accessing dev->platform_data directly. This is a cosmetic change
 in order to enhance readability and make the code simpler."

2. via the separate trees
It should go via the separate trees.

> 35 patches seem to be seperate mails and not threaded, so I can't easily
> check other opinions. Will skip for now unless somebody points out a
> strong reason.

3. Other opinions
Until now, there is no objection.
Also, 21 patches of all 35 patches have been applied by each maintainer.

Mark Brown,
Sorry for CC'ing you.
If I am wrong, please let me know kindly. :)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/