linux-kernel - Re: dmaengine: make dma_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA9_cmdLDxtmFJ=UM6jykWp25Eff4e=6m=vTVeDAkLxEj4YitQ@mail.gmail.com>
Date:	Mon, 19 Aug 2013 02:29:55 -0700
From:	Dan Williams <djbw@...com>
To:	Brice Goglin <Brice.Goglin@...ia.fr>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: dmaengine: make dma_channel_rebalance() NUMA aware

On Mon, Aug 19, 2013 at 1:54 AM, Brice Goglin <Brice.Goglin@...ia.fr> wrote:
> Le 19/08/2013 10:19, Dan Williams a écrit :
>>>   * @cap: capability to match
>>> - * @n: nth channel desired
>>> + * @cpu: cpu index which the channel should be close to
>>>   *
>>> - * Defaults to returning the channel with the desired capability and the
>>> - * lowest reference count when 'n' cannot be satisfied.  Must be called
>>> - * under dma_list_mutex.
>>> + * If some channels are close to the given cpu, the one with the lowest
>>> + * reference count is returned. Otherwise, cpu is ignored and only the
>>> + * reference count is taken into account.
>> I think we can drop these comments and the distinction, see below.
>
> I understand that we can remove the cpu==-1 case, but I don't see why we
> would remove the 3 last lines above. The code still looks for a
> NUMA-local channels first.

Ah yes, it still handles the "none local" case.

>
> Here's an updated patch with all your comments applied, except the
> removal of these 3 comment lines.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/