linux-kernel - Re: [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5211F191.7010303@baylibre.com>
Date:	Mon, 19 Aug 2013 12:21:05 +0200
From:	Benoit Cousson <bcousson@...libre.com>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	Chanwoo Choi <cw00.choi@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>, tony@...mide.com,
	myungjoo.ham@...sung.com, rob.herring@...xeda.com,
	pawel.moll@....com, mark.rutland@....com, ian.campbell@...rix.com,
	rob@...dley.net, george.cherian@...com, gregkh@...uxfoundation.org,
	linux-doc@...r.kernel.org, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux@....linux.org.uk, linux-kernel@...r.kernel.org, balbi@...com
Subject: Re: [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

Hi Kishon,

On 19/08/2013 11:29, Kishon Vijay Abraham I wrote:
> On Monday 19 August 2013 02:54 PM, Chanwoo Choi wrote:
>> On 08/19/2013 05:47 PM, Kishon Vijay Abraham I wrote:
>>> On Monday 19 August 2013 10:35 AM, Kishon Vijay Abraham I wrote:
>>>> Hi,
>>>>
>>>> On Saturday 17 August 2013 03:51 AM, Stephen Warren wrote:
>>>>> On 08/16/2013 04:20 AM, Kishon Vijay Abraham I wrote:
>>>>>> The Palmas device contains only a USB VID detector, so modified the
>>>>>> compatible type to *ti,palmas-usb-vid*.
>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt

That file is not yet in 3.11. Only the twl is there.
Is this one a rename of the twl one?

Regards,
Benoit

>>>>>
>>>>>>   PALMAS USB COMPARATOR
>>>>>>   Required Properties:
>>>>>> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
>>>>>> + - compatible : Should be "ti,palmas-usb-vid".
>>>>>
>>>>> Has the old value been published in a release kernel? If so, it makes
>>>>
>>>> No. This was merged only in 3.11-rc1. So I think we should take this version?
>>>> Chanwoo can you take this patch?
>>>
>>> Ah.. the old values will be part of 3.11 kernel. So should we retain the old
>>> values?
>>
>> What is the meaning of old value? previous value related to extcon-twl.txt?
>
> We were discussing on whether to have "ti,palmas-usb" or "ti,twl6035-usb" in
> compatible value in addition to "ti,palmas-usb-vid". Stephen wanted the old
> values ("ti,palmas-usb" or "ti,twl6035-usb") if it has been published in a
> release kernel.
>>
>> The extcon-twl.txt was included in 3.11 kernel
>
> Right. Since it's part of 3.11 kernel, I think we should retain the old
> compatible values.
>
> Thanks
> Kishon
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/