[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130819134038.GA27167@redhat.com>
Date: Mon, 19 Aug 2013 09:40:39 -0400
From: Mike Snitzer <snitzer@...hat.com>
To: Frank Mayhar <fmayhar@...gle.com>, linux-kernel@...r.kernel.org,
dm-devel@...hat.com
Subject: Re: dm: Make MIN_IOS, et al, tunable via sysctl.
On Sat, Aug 17 2013 at 8:30am -0400,
Alasdair G Kergon <agk@...hat.com> wrote:
> On Fri, Aug 16, 2013 at 03:55:21PM -0700, Frank Mayhar wrote:
> > This patch fixes that by changing the hardcoded MIN_IOS (and certain
> > other) #defines in dm-crypt, dm-io, dm-mpath, dm-snap and dm itself to
> > sysctl-modifiable values. This lets us change the size of these pools
> > on the fly, we can reduce the size of the pools and reduce memory
> > pressure.
>
> Did you consider using module_param_named()?
> (E.g. dm_verity_prefetch_cluster in dm-verity.)
Right, I'd prefer to see this be implemented in terms of
module_param_named(). Aside from dm-verity, dm-bufio.c makes the most
use of it.
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists