linux-kernel - Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376925802.10300.452.camel@misato.fc.hp.com>
Date:	Mon, 19 Aug 2013 09:23:22 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Cc:	mingo@...hat.com, hpa@...ux.intel.com, tglx@...utronix.de,
	gregkh@...uxfoundation.org, benh@...nel.crashing.org,
	fenghua.yu@...el.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	rjw@...k.pl, isimatu.yasuaki@...fujitsu.com,
	srivatsa.bhat@...ux.vnet.ibm.com, bp@...e.de,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 4/4] hotplug, powerpc, x86: Remove
 cpu_hotplug_driver_lock()

On Mon, 2013-08-19 at 10:20 -0500, Nathan Fontenot wrote:
> On 08/17/2013 02:46 PM, Toshi Kani wrote:
> > cpu_hotplug_driver_lock() serializes CPU online/offline operations
> > when ARCH_CPU_PROBE_RELEASE is set.  This lock interface is no longer
> > necessary with the following reason:
> > 
> >  - lock_device_hotplug() now protects CPU online/offline operations,
> >    including the probe & release interfaces enabled by
> >    ARCH_CPU_PROBE_RELEASE.  The use of cpu_hotplug_driver_lock() is
> >    redundant.
> >  - cpu_hotplug_driver_lock() is only valid when ARCH_CPU_PROBE_RELEASE
> >    is defined, which is misleading and is only enabled on powerpc.
> > 
> > This patch removes the cpu_hotplug_driver_lock() interface.  As
> > a result, ARCH_CPU_PROBE_RELEASE only enables / disables the cpu
> > probe & release interface as intended.  There is no functional change
> > in this patch.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@...com>
> 
> Reviewed-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>

Thanks Nathan!
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/