linux-kernel - Re: [PATCH] pinctrl: Pass all configs to driver on pin_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52126E06.1040108@wwwdotorg.org>
Date:	Mon, 19 Aug 2013 13:12:06 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Sherman Yin <syin@...adcom.com>
CC:	linux-kernel@...r.kernel.org, linus.walleij@...aro.org,
	linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org,
	matt.porter@...aro.org, csd@...adcom.com, mmayer@...adcom.com,
	james.hogan@...tec.com
Subject: Re: [PATCH] pinctrl: Pass all configs to driver on pin_config_set()

On 08/15/2013 04:42 PM, Sherman Yin wrote:
> When setting pin configuration in the pinctrl framework, pin_config_set() or
> pin_config_group_set() is called in a loop to set one configuration at a time
> for the specified pin or group.
> 
> This patch 1) removes the loop and 2) changes the API to pass the whole pin
> config array to the driver.  It is now up to the driver to loop through the
> configs.  This allows the driver to potentially combine configs and reduce the
> number of writes to pin config registers.
> 
> Signed-off-by: Sherman Yin <syin@...adcom.com>
> Reviewed-by: Christian Daudt <csd@...adcom.com>
> Reviewed-by: Matt Porter <matt.porter@...aro.org>

> Change-Id: I99cbfa2ae7b774456eb71edb276711b1ddcd42c8

That tag shouldn't be included in upstream patches.

>  drivers/pinctrl/pinconf.c             |   42 ++++----
>  drivers/pinctrl/pinctrl-tegra.c       |   69 ++++++------
>  include/linux/pinctrl/pinconf.h       |    6 +-

Those files, Reviewed-by: Stephen Warren <swarren@...dia.com>

On Tegra (Tegra114 Dalmore board, on top of next-20130816),
Tested-by: Stephen Warren <nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/