linux-kernel - Re: [PATCH] ARM: mmc: fix NONREMOVABLE test in sdhci-bcm-kona

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Aug 2013 16:30:00 -0700
From:	"Christian Daudt" <csd@...adcom.com>
To:	"Christian Daudt" <csd@...adcom.com>
cc:	"Chris Ball" <cjb@...top.org>,
	"Matt Porter" <matt.porter@...aro.org>,
	"Markus Mayer" <markus.mayer@...aro.org>,
	"Arnd Bergmann" <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
	csd_b@...dt.org
Subject: Re: [PATCH] ARM: mmc: fix NONREMOVABLE test in sdhci-bcm-kona

On 13-08-07 11:59 AM, Christian Daudt wrote:
> sdhci-bcm-kona driver is incorrectly doing "|" to bit-test
> NONREMOVABLE. Switch to "&"
>
> Reviewed-by: Markus Mayer <markus.mayer@...aro.org>
> Reviewed-by: Matt Porter <matt.porter@...aro.org>
> Signed-off-by: Christian Daudt <csd@...adcom.com>
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 87175f9..9ffac0b 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -263,7 +263,7 @@ static int __init sdhci_bcm_kona_probe(struct platform_device *pdev)
>   		(mmc_gpio_get_cd(host->mmc) != -ENOSYS) ? 'Y' : 'N',
>   		(mmc_gpio_get_ro(host->mmc) != -ENOSYS) ? 'Y' : 'N');
>   
> -	if (host->mmc->caps | MMC_CAP_NONREMOVABLE)
> +	if (host->mmc->caps & MMC_CAP_NONREMOVABLE)
>   		host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>   
>   	dev_dbg(dev, "is_8bit=%c\n",
> @@ -282,7 +282,7 @@ static int __init sdhci_bcm_kona_probe(struct platform_device *pdev)
>   	}
>   
>   	/* if device is eMMC, emulate card insert right here */
> -	if (host->mmc->caps | MMC_CAP_NONREMOVABLE) {
> +	if (host->mmc->caps & MMC_CAP_NONREMOVABLE) {
>   		ret = sdhci_bcm_kona_sd_card_emulate(host, 1);
>   		if (ret) {
>   			dev_err(dev,
applied to bcm/for-3.12/soc

  thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/