| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Aug 2013 16:35:29 -0700 From: Jerry Snitselaar <jerry.snitselaar@...cle.com> To: "Rafael J. Wysocki" <rjw@...k.pl> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@...cle.com> > > > > Looks good to me. > > > > Acked-by: Mika Westerbeg <mika.westerberg@...ux.intel.com> > > Well, OK, but do we need to be able to build that as a module? > > Maybe it should just be yes or no? > > Rafael > Perhaps have depends on I2C=y and be a bool instead of tristate? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists