linux-kernel - Re: [PATCH] proc: return on proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwqQBdYUU2MfccDpzc2S+oiP23QKdbPnfJsnVw1TR_H+Q@mail.gmail.com>
Date:	Mon, 19 Aug 2013 16:49:26 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Marc Dionne <marc.c.dionne@...il.com>
Cc:	Richard Genoud <richard.genoud@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] proc: return on proc_readdir error

On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne <marc.c.dionne@...il.com> wrote:
>
> By my reading that commit (f0c3b5093add) also made proc_readdir always
> return 0, so with this patch the effect I see is that no pid entries
> are listed under /proc, breaking ps for instance.  I don't see how
> even the previous version of proc_readdir could return a negative
> value; looks like 1 and 0 were the only possible return values.

Yes, see the other thread. The "return 1" case had gotten lost. I
think current git should get everything right, but please do test. I
did some testing of my own with a random little getdents test-program
(just checking that it got the same results with different (small)
buffer sizes), but it was by no means exhaustive.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/