linux-kernel - Re: [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5212D2B8.6090602@windriver.com>
Date:	Tue, 20 Aug 2013 10:21:44 +0800
From:	"Li.Wang" <Li.Wang@...driver.com>
To:	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call()

Hi All,

Anybody help me review this?

Thanks,
LiWang.

On 08/14/2013 10:20 AM, Li Wang wrote:
> When cpuidle_idle_call() return 0, it shows that linux system is using
> idle framwork driver. Now, local irq has already been enabled in
> cpuidle_idle_call(). So, it need not enable local irq again, when return 0.
>
> The code is introduced by commit:
> 97a5b81fa4d3a11dcdf224befc577f2e0abadc0b ("x86: Fix idle consolidation fallout")
> In that defect, it does not use idle framework driver, just call amd_e400_idle().
> That problem is that amd_e400_idle() does not enable irq.
>
> Signed-off-by: Li Wang <li.wang@...driver.com>
> ---
>   arch/x86/kernel/process.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 83369e5..cb55ee4 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -300,8 +300,6 @@ void arch_cpu_idle(void)
>   {
>   	if (cpuidle_idle_call())
>   		x86_idle();
> -	else
> -		local_irq_enable();
>   }
>   
>   /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/