linux-kernel - Re: [PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52131732.2060306@slimlogic.co.uk>
Date:	Tue, 20 Aug 2013 08:13:54 +0100
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Samuel Ortiz <sameo@...ux.intel.com>
CC:	Grygorii Strashko <grygorii.strashko@...com>,
	Lee Jones <lee.jones@...aro.org>,
	Kevin Hilman <khilman@...aro.org>, linux-omap@...r.kernel.org,
	Ruslan Bilovol <ruslan.bilovol@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support

On 20/08/13 02:01, Samuel Ortiz wrote:
> Hi Grygorii,
>
> On Thu, Jul 25, 2013 at 04:15:46PM +0300, Grygorii Strashko wrote:
>> This patch series intorduces twl6030-irq module rework to use Threaded IRQ and
>> linear irq_domain, and adds support for PMIC TWL6032 IRQs.
>>
>> After this patch series TWL6030/6032 IRQs will be supported only for DT boot mode.
>>
>> Changes since v1:
>> - Added new patch "mfd: twl6030-irq: create struct twl6030_irq"
>>    which introduces "struct twl6030_irq" to store all local variables inside it.
>> - Patch "mfd: twl6030-irq: migrate to IRQ threaded handler":
>>    Minor comments applied; fixed twl6030_exit_irq();
>>    The Parent IRQ has been set for each nested IRQ.
>> - Patch "mfd: twl6030-irq: convert to use linear irq_domain":
>>    The irq_find_mapping() is used in twl6030_mmc_card_detect_config()
>>    to get virtual IRQ number.
> This looks good to me. Kevin, Graeme, any further comments/ACKs ?
>
> Cheers,
> Samuel.
>
Yes, it looked good to me as well.

Acked-by: Graeme Gregory <gg@...mlogic.co.uk>

G

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/