linux-kernel - Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when using OF Platform"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52132187.5030103@antcom.de>
Date:	Tue, 20 Aug 2013 09:57:59 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Christophe Leroy <christophe.leroy@....fr>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when
 using OF Platform"

On 08/20/2013 08:29 AM, Christophe Leroy wrote:
> This patch reverts commit 047b93a35961f7a6561e6f5dcb040738f822b892 which breaks
> MAX7301 GPIO driver because that commit was dependant on a rejected patch that
> was implementing selection of SPI speed from the Device Tree.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>

Acked-by: Roland Stigge <stigge@...com.de>

Good, thanks!

> 
> --- linux-3.11-rc6/drivers/gpio/gpio-max7301.c	2013-08-17 21:09:17.000000000 +0200
> +++ linux/drivers/gpio/gpio-max7301.c	2013-08-18 06:31:52.000000000 +0200
> @@ -56,8 +56,7 @@
>  	int ret;
>  
>  	/* bits_per_word cannot be configured in platform data */
> -	if (spi->dev.platform_data)
> -		spi->bits_per_word = 16;
> +	spi->bits_per_word = 16;
>  	ret = spi_setup(spi);
>  	if (ret < 0)
>  		return ret;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/