linux-kernel - Re: [PATCH 2/5] page_migrate: Fix wrong comment in address_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1308201302290.21654@pobox.suse.cz>
Date:	Tue, 20 Aug 2013 13:02:48 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Tang Chen <tangchen@...fujitsu.com>
Cc:	bcrl@...ck.org, akpm@...ux-foundation.org, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] page_migrate: Fix wrong comment in
 address_space_operations->migratepage()

On Thu, 20 Jun 2013, Tang Chen wrote:

> There is no parameter "sync" in address_space_operations->migratepage().
> It should be mograte_mode. And the comment is for MIGRATE_ASYNC.

I am fixing this typo in changelog :) and applying the series.

> 
> Signed-off-by: Tang Chen <tangchen@...fujitsu.com>
> ---
>  include/linux/fs.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 43db02e..c1a76ac 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -372,8 +372,8 @@ struct address_space_operations {
>  	int (*get_xip_mem)(struct address_space *, pgoff_t, int,
>  						void **, unsigned long *);
>  	/*
> -	 * migrate the contents of a page to the specified target. If sync
> -	 * is false, it must not block.
> +	 * migrate the contents of a page to the specified target. If
> +	 * migrate_mode is MIGRATE_ASYNC, it must not block.
>  	 */
>  	int (*migratepage) (struct address_space *,
>  			struct page *, struct page *, enum migrate_mode);
> -- 
> 1.7.1
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/