linux-kernel - Re: mfd: as3722: introducing ams AS3722 PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130820115646.GJ23699@lee--X1>
Date:	Tue, 20 Aug 2013 12:56:46 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Florian Lobmaier <florian.lobmaier@....com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: mfd: as3722: introducing ams AS3722 PMIC driver

On Tue, 20 Aug 2013, Florian Lobmaier wrote:
> Thank you for the response regarding the correct formatting of the patches. I will try to fulfill the requirements as expected. Now tried to introduce the as3722 mfd driver in logical steps. Please keep in mind that the driver is already fully written, so the bit-by-bit introduction within the files would be a really hard requirement to fulfill.

So this is still not split up in the way that we'd normally
expect. You're still splitting up the patches per *file*, when in
actual fact, they should be split up by *functionality*. I think this
is the third time I've mentioned this.

I've also said something similar here, which might be easier to
understand:
  http://www.spinics.net/lists/netdev/msg246457.html

You need to learn how to use `git add -i` if you're going to get this
right (the other way is to copy and paste pieces of code into a file
before saving and committing, but I suggest you master the former
suggestion). You need to be adding to the patches a hunk at a time, or
even smaller using `git add`s 'edit' capability.

> One question I have still in mind: How do I reply correctly to already sent mails? Which command is recommended in this case?

To reply to emails on the list, you just need to use your standard
email client in the normal way.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/