linux-kernel - Re: [PATCH] arm64: add screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Aug 2013 14:37:33 +0100
From:	Will Deacon <will.deacon@....com>
To:	Mark Salter <msalter@...hat.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Catalin Marinas <Catalin.Marinas@....com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: add screen_info for console support

Hi Mark,

On Sun, Aug 18, 2013 at 05:22:50PM +0100, Mark Salter wrote:
> The arm64 port doesn't provide a screen_info struct for console support
> which leads to a build failure with some configurations:
> 
>   drivers/video/console/vgacon.c:820: undefined reference to `screen_info'
> 
> This patch adds an empty declaration of screen_info to fix the build
> problem. Some additional runtime code is needed to actually make it
> useful.
> 
> Signed-off-by: Mark Salter <msalter@...hat.com>
> ---
>  arch/arm64/kernel/setup.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index add6ea6..eb9f93a 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -64,6 +64,10 @@ static const char *cpu_name;
>  static const char *machine_name;
>  phys_addr_t __fdt_pointer __initdata;
>  
> +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_DUMMY_CONSOLE)                                               
> +struct screen_info screen_info;                                                                                
> +#endif                                                                                                         

You may be able to do something similar to the proposal for PARPORT here and
factor out the lengthy "depends on" clause for VGA_CONSOLE instead of adding
the dummy info.

Unfortunately, I can't make any promise of further bonus points :)

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/