linux-kernel - Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E7A4BEAB-CBFD-41BF-A6DE-981F74FDB2CF@codeaurora.org>
Date:	Tue, 20 Aug 2013 09:51:55 -0500
From:	Kumar Gala <galak@...eaurora.org>
To:	Pawel Moll <pawel.moll@....com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	"ohad@...ery.com" <ohad@...ery.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	Mark Rutland <Mark.Rutland@....com>,
	Ian Campbell <ian.campbell@...rix.com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	Jeffrey Hugo <jhugo@...eaurora.org>,
	Eric Holmberg <eholmber@...eaurora.org>
Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block


On Aug 19, 2013, at 6:12 AM, Pawel Moll wrote:

> On Fri, 2013-08-16 at 23:54 +0100, Stephen Warren wrote:
>> Indeed, I tend to think that reg-names is a bad idea.
>> 
>> IIRC, the rule for "reg" is that entries must always have a defined
>> order, so that it can always be accessed by integer index. 
> 
> First time I hear about that rule, really...
> 
>> And given
>> that's true, allowing for reg-names just creates confusion since it
>> implies you can look up the index in reg-names and then read reg at that
>> index.
> 
> I actually believe that named resources leave less are for error than
> indexed ones. And this is the message I remember being "spread" in the
> times of static platform devices.
> 
> Pawel

I can understand that reg-names being optional for older bindings to ensure backwards compat, but for newer ones agree that it is less error prone.  This is something we should try to come to some agreement on.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/