linux-kernel - Re: [PATCH 2/2] usb: fail on usb_hub_create_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1308201415020.1591-100000@iolanthe.rowland.org>
Date:	Tue, 20 Aug 2013 14:18:57 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Krzysztof Mazur <krzysiek@...lesie.net>
cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>,
	Daniel J Blueman <daniel@...ascale-asia.com>
Subject: Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

On Tue, 20 Aug 2013, Krzysztof Mazur wrote:

> Ignoring usb_hub_create_port_device() errors cause later NULL pointer
> deference when uninitialized hub->ports[i] entries are dereferenced
> after port memory allocation error.
> 
> Signed-off-by: Krzysztof Mazur <krzysiek@...lesie.net>
> ---
> I'm not sure if failing in that case is a good idea, but other solutions
> are more complex.
> 
> I tried also changing hdev->maxchild and skiping initialization
> of later ports, but it didn't work because in some cases
> hub->descriptor->bNbrPorts is used instead of hdev->maxchild.
> With simulated usb_hub_create_port_device() failure I have an Oops
> in hub_power_on().

I think this patch is correct.  However, we also should change the 
other places that refer to bNbrPorts; make them use maxchild instead.

> Another possible solution is allowing for uninitialized ports and
> checking for hub->ports[i] == NULL.

No, if we can't allocate memory for all the ports then the whole thing 
should fail.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/