linux-kernel - Re: [PATCH V3] regulator: palmas: add support for external control of rails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130820191339.GT30073@sirena.org.uk>
Date:	Tue, 20 Aug 2013 20:13:39 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	sameo@...ux.intel.com, swarren@...dotorg.org,
	rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com,
	rob@...dley.net, lee.jones@...aro.org, grant.likely@...aro.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, gg@...mlogic.co.uk, kishon@...com,
	j-keerthy@...com, ian.campbell@...rix.com
Subject: Re: [PATCH V3] regulator: palmas: add support for external control
 of rails

On Tue, Aug 20, 2013 at 06:44:15PM +0530, Laxman Dewangan wrote:

> +			econtrol = PALMAS_EXT_CONTROL_NSLEEP;
> +			if (!ret) {
> +				if (prop == 1)
> +					econtrol = PALMAS_EXT_CONTROL_ENABLE1;
> +				else if (prop == 2)
> +					econtrol = PALMAS_EXT_CONTROL_ENABLE2;
> +				else if (prop == 3)
> +					econtrol = PALMAS_EXT_CONTROL_NSLEEP;

Since Stephen identified an issue as well...  this looks like a switch
statement.   Otherwise this looks fine.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)