linux-kernel - Re: [PATCH v7 1/1] input: ideapad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130820194527.GA22595@core.coreip.homeip.net>
Date:	Tue, 20 Aug 2013 12:45:27 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Andrey Moiseev <o2g.org.ru@...il.com>
Cc:	linux-input@...r.kernel.org, arnoques@...il.com,
	russianneuromancer@...ru, ike.pan@...onical.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/1] input: ideapad_slidebar: new input driver

Hi Andrey,

On Fri, Aug 16, 2013 at 10:58:45AM +0400, Andrey Moiseev wrote:
> v7: fixed things addressed by Dmitry Torokhov to v7 (quoted message goes below the patch)
> 

This looks almost perfect, I have just one question:

> +static bool slidebar_i8042_filter(unsigned char data, unsigned char str,
> +				struct serio *port)
> +{
> +	static bool extended = false;
> +
> +	/* Scancodes: e03b on move, e0bb on release */
> +	if (unlikely(data == 0xe0)) {
> +		extended = true;
> +		return false;
> +	} else if (unlikely(extended && (data == 0x3b))) {
> +		extended = false;
> +		input_report_key(slidebar_input_dev, BTN_TOUCH, 1);
> +		input_report_abs(slidebar_input_dev, ABS_X, slidebar_pos_get());
> +		input_sync(slidebar_input_dev);
> +		return false;
> +	} else if (unlikely(extended && (data == 0xbb))) {
> +		input_report_key(slidebar_input_dev, BTN_TOUCH, 0);
> +		input_sync(slidebar_input_dev);

Don't you need to reset 'extended" here as well?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/