linux-kernel - Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377032302.2016.75.camel@joe-AO722>
Date:	Tue, 20 Aug 2013 13:58:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	liujunliang_ljl <liujunliang_ljl@....com>, gregkh <gregkh@...e.de>,
	sunhecheng <sunhecheng@....126.com>,
	linux-usb <linux-usb@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device
 Driver into the Linux Kernel

On Tue, 2013-08-20 at 22:46 +0200, Francois Romieu wrote:
> liujunliang_ljl <liujunliang_ljl@....com> :

> > +	if (i >= SR_SHARE_TIMEOUT) {
> > +		netdev_err(dev->net, "%s read timed out!", phy ? "phy" : "eeprom");

netdev_<level>, like almost all other printk
messages needs a terminating "\n" newline to
avoid any possible message interleaving by other
printks.

> > +	if (!is_valid_ether_addr(addr->sa_data)) {
> > +		dev_err(&net->dev, "not setting invalid mac address %pM\n",
> > +								addr->sa_data);
> 
> 		dev_err(&net->dev, "not setting invalid mac address %pM\n",
> 			addr->sa_data);

prefer netdev_<level> to dev_<level> where possible.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/