linux-kernel - Re: [PATCH v3 trivial 0/7] Miscellaneous Trivialities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1377044377.2737.87@driftwood>
Date:	Tue, 20 Aug 2013 19:19:37 -0500
From:	Rob Landley <rob@...dley.net>
To:	Michael Witten <mfwitten@...il.com>
Cc:	Jiri Kosina <trivial@...nel.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 trivial 0/7] Miscellaneous Trivialities

On 08/20/2013 05:27:53 PM, Michael Witten wrote:
> On Tue, 20 Aug 2013 16:20:02 -0500, Rob Landley wrote:
> > On 08/20/2013 11:02:42 AM, Michael Witten wrote:
> >> I've been sitting on some trivial patches for a while, and I'd just
> >> like to get them out of the way.
> >>
> >> Here is the series:
> >>
> >>   [1] Docs: Kconfig: For readability, offset modifiers with commas
> >>   [2] Docs: Kconfig: Use consistent whitespace indentation
> >>   [3] Docs: Kconfig: Clean up the radiotap documentation
> >
> > Not a single worthwhile change in any of those three.
> >
> > Excuse me:
> >
> > Not a single, worthwhile change, in any of those three.
> 
> Actually, your second attempt doesn't use commas properly.

Sorry, forgot the <shatner> tags. (Or possibly <sarcasm>.)

> In any case, this is *trivial*, miscellaneous work. I do not pretend
> to be making a major contribution; this is why I sent these patches  
> `To:'
> 
>   Jiri Kosina <TRIVIAL@...nel.org>
> 
> Other people are included as some kind of courtesy, and also so that
> any change that is actually non-trivial might be caught (as with the
> `hotplug' patch).

If you were modifying the vfs would you cc the VFS maintainer as a  
"courtesy" too?

> >>   [4] Docs: Kconfig: `devlopers' -> `developers'
> >
> > Sure, a typo, why not.
> 
> When does a series of *trivial* changes become worthwhile? What's  
> wrong
> with making refinements when it costs nothing? Must one always hide
> trivial alterations inside something more substantial?

Because some people actually read the commit logs and changes that  
don't do anything add noise for no benefit? (Your fourth change was a  
single typo fix. The previous three changes _combined_ were less  
valuable than that single typo fix. Hence asking if we really needed  
three separate commits to accomplish something that didn't actually  
need to be done in the first place.)

> All right. I get it; you personally don't give a damn. I certainly
> don't hold that against you. However, there *are* people who *do*
> care about such refinements, and a nasty, condescending email
> isn't going to alter our behavior.

Actually my objection is that it's not worth the churn in the commit  
logs.

But yeah, why would a guy listed in MAINTAINERS as caring about the  
Documentation directory pay attention to proposed changes to the  
Documentation directory? Madness. I'll butt out now...

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/