linux-kernel - Re: [PATCH 5/9] target: Skip ->queue_data_in() callbacks for COMPARE_AND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130821063223.GG25506@infradead.org>
Date:	Tue, 20 Aug 2013 23:32:23 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	"Nicholas A. Bellinger" <nab@...erainc.com>
Cc:	target-devel <target-devel@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Martin Petersen <martin.petersen@...cle.com>,
	Chris Mason <chris.mason@...ionio.com>,
	James Bottomley <JBottomley@...allels.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: Re: [PATCH 5/9] target: Skip ->queue_data_in() callbacks for
 COMPARE_AND_WRITE

> @@ -1832,7 +1832,8 @@ static void transport_complete_qf(struct se_cmd *cmd)
>  		ret = cmd->se_tfo->queue_data_in(cmd);
>  		break;
>  	case DMA_TO_DEVICE:
> -		if (cmd->t_bidi_data_sg) {
> +		if (cmd->t_bidi_data_sg &&
> +		    cmd->t_task_cdb[0] != COMPARE_AND_WRITE) {

This is not the place to hardcode specific cdb opcodes.  Should be
a flag with a defined meaning on the command.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/