linux-kernel - Re: [PATCH] [TRIVIAL] Remove braces in drivers/scsi/in2000.h to fix build for clang. No functional change otherwise.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130821065018.GB9043@infradead.org>
Date:	Tue, 20 Aug 2013 23:50:18 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	dl9pf@....de
Cc:	PaX Team <pageexec@...email.hu>,
	Behan Webster <behanw@...verseincode.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Remove braces in drivers/scsi/in2000.h to fix
 build for clang. No functional change otherwise.

On Tue, Aug 20, 2013 at 11:19:06PM +0200, dl9pf@....de wrote:
> From: Jan-Simon M??ller <dl9pf@....de>
> 
> Author:  PaX Team <pageexec at freemail.hu>
> ML-Post: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
> URL:     http://llvm.linuxfoundation.org
> 
> Merge:   Jan-Simon M??ller <dl9pf at gmx.de>
> 
> Description:
>   Clang chokes on the notation "insw (%%dx)" but works for "insw %%dx" (outsw likewise);
>   GNU as accepts both forms.
> 
> Signed-off-by: Jan-Simon M??ller <dl9pf@....de>

I think the right fix is to simply kill the FAST_READ_IO/FAST_WRITE_IO
defines and their associated inline assembly entirely.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/