lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Aug 2013 00:02:55 -0700 (PDT) From: David Miller <davem@...emloft.net> To: acking@...are.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, pv-drivers@...are.com Subject: Re: [PATCH] VMXNET3: Add support for virtual IOMMU From: Andy King <acking@...are.com> Date: Tue, 20 Aug 2013 10:33:32 -0700 > We can't just do virt_to_phys() on memory that we pass to the device and > expect it to work in presence of a virtual IOMMU. We need to add IOMMU > mappings for such DMAs to work correctly. Fix that with > pci_alloc_consistent() where possible, or pci_map_single() where the > mapping is short-lived or we don't control the allocation (netdev). > > Also fix two small bugs: > 1) use after free of rq->buf_info in vmxnet3_rq_destroy() > 2) a cpu_to_le32() that should have been a cpu_to_le64() > > Acked-by: George Zhang <georgezhang@...are.com> > Acked-by: Aditya Sarwade <asarwade@...are.com> > Signed-off-by: Andy King <acking@...are.com> Please use dma_alloc_coherent() (or in fact dma_zalloc_coherent()), dma_map_single() et al., because they are preferred and in particular allow specification of GFP_* flags. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists