linux-kernel - Re: [REGRESSION] 3.10.{6,7} crashes on network activity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52147FD2.9020401@broadcom.com>
Date:	Wed, 21 Aug 2013 10:52:34 +0200
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Josh Boyer" <jwboyer@...oraproject.org>
cc:	"Felix Fietkau" <nbd@...nwrt.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Tom Gundersen" <teg@...m.no>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Linux Wireless List" <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Johannes Berg" <johannes@...solutions.net>
Subject: Re: [REGRESSION] 3.10.{6,7} crashes on network activity

On 08/21/2013 02:11 AM, Josh Boyer wrote:
> On Tue, Aug 20, 2013 at 4:15 AM, Arend van Spriel <arend@...adcom.com> wrote:
>> On 08/20/2013 06:56 AM, Felix Fietkau wrote:
>>>
>>> On 2013-08-20 2:28 AM, Greg Kroah-Hartman wrote:
>>>>
>>>> On Tue, Aug 20, 2013 at 08:26:11AM +0800, Tom Gundersen wrote:
>>>>>
>>>>> On Tue, Aug 20, 2013 at 8:03 AM, Greg Kroah-Hartman
>>>>> <gregkh@...uxfoundation.org> wrote:
>>>>>>
>>>>>> On Tue, Aug 20, 2013 at 07:59:47AM +0800, Tom Gundersen wrote:
>>>>>>>
>>>>>>> Hi guys,
>>>>>>>
>>>>>>> Starting with 3.10.6 (and still present in .7) I get an oops on
>>>>>>> connecting to the network.
>>>>>>>
>>>>>>> The attached picture shows the oops. In case it does not reach the ML,
>>>>>>> the top of the call trace reads:
>>>>>>>
>>>>>>> brcms_c_compute_rtscts_dur
>>>>>>> brcms_c_ampdu_finalize
>>>>>>> ampdu_finalize
>>>>>>> dma_txfast
>>>>>>> brcms_c_txfifo
>>>>>>> brcms_c_sendpkt_mac80211
>>>>>>> brcms_ops_tx
>>>>>>> __ieee80211_tx
>>>>>>>
>>>>>>> I bisected the problem and the first bad commit is
>>>>>>>
>>>>>>> commit ef47a5e4f1aaf1d0e2e6875e34b2c9595897bef6
>>>>>>> Author: Felix Fietkau <nbd@...nwrt.org>
>>>>>>> Date:   Fri Jun 28 21:04:35 2013 +0200
>>>>>>>
>>>>>>>       mac80211/minstrel_ht: fix cck rate sampling
>>>>>>>
>>>>>>>       commit 1cd158573951f737fbc878a35cb5eb47bf9af3d5 upstream.
>>>>>>>
>>>>>>> Reverting it on top of .7 fixes the problem.
>>>>>>>
>>>>>>> I had the same (I suppose) problem on mainline some time ago, but I
>>>>>>> have not bisected it, verified that the problem still occurs there, or
>>>>>>> checked if reverting the upstream patch fixes it. I'd be happy to do
>>>>>>> that if it would help though.
>>>>>>>
>>>>>>> Let me know if you need any more information.
>>>>>>
>>>>>>
>>>>>> Do you have this same problem with 3.11-rc6 as well?
>>>>>
>>>>>
>>>>> Yes, I just confirmed. I also confirmed that reverting the mainline
>>>>> commit on top of -rc6 fixes the problem.
>>>>
>>>>
>>>> Great, thanks.
>>>>
>>>> Felix and Johannes, any chance we can get this reverted in Linus tree
>>>> soon, and push that revert back to the 3.10 stable tree as well?
>>>
>>> I'd like to avoid a revert, since that will simply replace one set of
>>> issues with another. Let's limit the use of the feature that brcmsmac
>>> can't handle to drivers that are known to work with it. Tom, Please
>>> test this patch to see if it fixes your issue.
>>
>>
>> Hi Felix,
>>
>> I have been diving into root causing why brcmsmac can not handle cck
>> fallback rates, because it should. Maybe it is better to flag no cck support
>> and only change brcmsmac.
>
> We have a number of users hitting this in Fedora 18 and 19 now.  We're
> tracking it with https://bugzilla.redhat.com/show_bug.cgi?id=998080
> and I'm sure we can find people to test easily.

There is already another one (possibly) dealing with the same issue:

https://bugzilla.redhat.com/show_bug.cgi?id=989269

One of them should probably be flagged as duplicate.

> If you have a patch disabling cck in brcmsmac, I'd be happy to build a
> kernel for people.  If that's going to be some time coming, perhaps
> it's better to grab Felix's patch on a temporary basis?

I think it is better to grab Felix's patch because as we both observed 
there is stuff missing in brcmsmac to deal with CCK rates and A-MPDU 
packet aggregation.

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/