linux-kernel - Re: [PATCH v1 1/2] perf: add attr->mmap2 attribute to an event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Aug 2013 11:56:44 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung.kim@....com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v1 1/2] perf: add attr->mmap2 attribute to an event

On Mon, Aug 19, 2013 at 11:14 AM, Stephane Eranian <eranian@...gle.com> wrote:
> On Thu, Aug 15, 2013 at 12:26 PM, Peter Zijlstra <peterz@...radead.org> wrote:
>> On Tue, Aug 13, 2013 at 01:55:56PM +0200, Stephane Eranian wrote:
>>
>>> @@ -638,6 +639,25 @@ enum perf_event_type {
>>>        */
>>>       PERF_RECORD_SAMPLE                      = 9,
>>>
>>> +     /*
>>> +      * The MMAP2 records are an augmented version of MMAP, they add
>>> +      * maj, min, ino numbers to be used to uniquely identify each mapping
>>> +      *
>>> +      * struct {
>>> +      *      struct perf_event_header        header;
>>> +      *
>>> +      *      u32                             pid, tid;
>>> +      *      u64                             addr;
>>> +      *      u64                             len;
>>> +      *      u64                             pgoff;
>>> +      *      u32                             maj;
>>> +      *      u32                             min;
>>> +      *      u64                             ino;
>>> +      *      char                            filename[];
>>
>> Did you forget the sample_id stuff?
>>
>>                 struct sample_id                sample_id;
>>
> Ok, will add that and the i_generation field.

Added that now, works fine. Except it won't be availa when synthesizing
MMAP records from /proc/PID/maps because it is not displayed there.
There is not much we can do about this. And of course, there is not i_generation
for kernel level ELF images.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/