linux-kernel - Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Aug 2013 11:35:32 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	George Cherian <george.cherian@...com>
CC:	balbi@...com, myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, grant.likely@...aro.org,
	rob@...dley.net, ian.campbell@...rix.com, mark.rutland@....com,
	pawel.moll@....com, rob.herring@...xeda.com,
	linux-omap@...r.kernel.org, linux-usb@...r.kernel.org,
	bcousson@...libre.com
Subject: Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB
 ID detection

On 08/21/2013 07:06 AM, George Cherian wrote:
> Hi Stephen,
> 
> On 8/20/2013 10:23 PM, Stephen Warren wrote:
>>> >ID pins are connected to pcf8575, and the pcf8575's interrupt line is
>>> >inturn connected to
>>> >gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin
>>> change.
>> In that case, the PCF8575 node needs to be a GPIO controller and an IRQ
>> controller, as does the driver for the PCF8575. This binding should have
>> a single entry in the gpios property, and the driver can call
>> gpio_to_irq() on that so it knows which IRQ to request.
> 
> You meant some thing like this?
> 
>        pcf_usb: pcf8575@21 {
>                 compatible = "ti,pcf8575";
>                 reg = <0x21>;
>                 gpio-controller;
>                 #gpio-cells = <2>;
>                 interrupt-parent = <&gpio6>;
>                 interrupts = <11 2>;
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
>      };
> 
>      usb_vid_gpio {
>                 compatible = "ti,dra7xx-usb";
>                 gpios = <&pcf_usb 1 0>;
>      };

Yes.

Except that the compatible value for the usb_vid_gpio node still looks
wrong, since I think that node isn't anything to do with any particular SoC.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/