lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 21 Aug 2013 19:28:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Florian Lobmaier <florian.lobmaier@....com>,
	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH 4/4] mfd: as3722: introduce regmap support

On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote:
> On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> > Signed-off-by: Florian Lobmaier <florian.lobmaier@....com>
> > ---
> >  drivers/mfd/as3722-regmap.c |  417 +++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 417 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/mfd/as3722-regmap.c

> I'll leave the review of this file to Mark, but it should be added
> either when you start calling the functions, or at least before they
> are used, or else the preceding commits won't build. This would cause
> someone a major headache if their bisect landed in the middle of your
> patches.

Mark wasn't CCed and only happened to notice this on the list...  might
be worth checking!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ