linux-kernel - Re: [PATCH] kernel/module.c: use scnprintf() instead of sprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52142008.203@asianux.com>
Date:	Wed, 21 Aug 2013 10:03:52 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/module.c: use scnprintf() instead of sprintf()

On 08/20/2013 02:04 PM, Rusty Russell wrote:
> Chen Gang <gang.chen@...anux.com> writes:
> 
>> For some strings, they are permitted to be larger than PAGE_SIZE, so
>> need use scnprintf() instead of sprintf(), or it will cause issue.
>>
>> One case is:
>>
>>   if a module version is crazy defined (length more than PAGE_SIZE),
>>   'modinfo' command is still OK (print full contents),
>>   but for "cat /sys/modules/'modname'/version", will cause issue in kernel.
> 
> Applied!
> 

Thanks.

> Thanks,
> Rusty.
> 
>>
>> Signed-off-by: Chen Gang <gang.chen@...anux.com>
>> ---
>>  kernel/module.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/module.c b/kernel/module.c
>> index 2069158..0618e63 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -603,7 +603,7 @@ static void setup_modinfo_##field(struct module *mod, const char *s)  \
>>  static ssize_t show_modinfo_##field(struct module_attribute *mattr,   \
>>  			struct module_kobject *mk, char *buffer)      \
>>  {                                                                     \
>> -	return sprintf(buffer, "%s\n", mk->mod->field);               \
>> +	return scnprintf(buffer, PAGE_SIZE, "%s\n", mk->mod->field);  \
>>  }                                                                     \
>>  static int modinfo_##field##_exists(struct module *mod)               \
>>  {                                                                     \
>> -- 
>> 1.7.7.6
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/