linux-kernel - Re: [PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdauvk4Gw_k6TaYSH32nA66M_MHHksx6ESrqYx1PetWdug@mail.gmail.com>
Date:	Wed, 21 Aug 2013 23:42:09 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Patrice Chotard <patrice.chotard@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

On Mon, Aug 19, 2013 at 4:07 AM, Axel Lin <axel.lin@...ics.com> wrote:

> This one is missed in commit 42fed7ba "pinctrl: move subsystem mutex to
> pinctrl_dev struct".

I think this was never there.

> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/pinctrl/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index 53c40d9..92f86ab 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -562,11 +562,15 @@ int pinctrl_request_gpio(unsigned gpio)
>                 return ret;
>         }
>
> +       mutex_lock(&pctldev->mutex);
> +
>         /* Convert to the pin controllers number space */
>         pin = gpio_to_pin(range, gpio);
>
>         ret = pinmux_request_gpio(pctldev, range, pin, gpio);
>
> +       mutex_unlock(&pctldev->mutex);
> +
>         return ret;

What is this protecting against?

I'm not sure I follow this so better ask.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/